Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Integration test with B0 (trivial) model #85

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

oesteban
Copy link
Member

Drops the use of a real AFNI series of transforms. Instead, generate a number of large-yet-plausible transformations for head motion.

I have visually checked a few things:

  • NiTransforms correctly generates the dataset with motion, and when realigining it with the originally created transforms, indeed the dataset does not show any motion (uncomment line writing out ground_truth.nii.gz to see). Meaning, NiTransforms seems to be a reliable tool for this test.
  • The correction by our estimator is ATM not great, but we are just testing the integration of all pieces (see Integration and validation tests with b=0 only #40 for comments on fine-tuning).

Follow-up: #84.
Part-of: #40.

@oesteban oesteban requested a review from arokem August 25, 2022 12:23
Drops the use of a real AFNI series of transforms. Instead, generate a
number of large-yet-plausible transformations for head motion.

Follow-up: #84.
Part-of: #40.
@oesteban
Copy link
Member Author

Merging this makes all tests pass locally :)

@oesteban
Copy link
Member Author

I'll go ahead and merge. I want to start sending CI/CD to Circle and would prefer tests to be passing :)

@oesteban oesteban merged commit 5e2cfbb into main Aug 26, 2022
@oesteban oesteban deleted the fix/trivial-model-test branch August 26, 2022 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant